Skip to content

Drop systematic lines that do not affect any channel/process when cal… #1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anigamova merged 2 commits into from
Mar 18, 2026
Merged

Drop systematic lines that do not affect any channel/process when cal… #1238

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f72c9a9
drop systematic lines that do not affect any channel/process when cal…
maxgalli Mar 16, 2026
08d45f3
lint combineCards.py
maxgalli Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions scripts/combineCards.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,15 @@ def compareParamSystLines(a, b):
if process_errors:
raise RuntimeError("ERROR: mismatch between process signal labels:\n%s" % ("\n".join(process_errors)))

# Remove systematics that don't affect any process/channel in the combination
removed_systs = {name for name, (pdf, pdfargs, effect, nofloat) in systlines.items() if not any(effect.get(b, {}).get(p, "-") != "-" for b, p, s in keyline)}
for name in removed_systs:
del systlines[name]

# Remove pruned systematics from groups - leave all other group members untouched
if removed_systs:
groups = {gname: nuisanceNames - removed_systs for gname, nuisanceNames in groups.items() if nuisanceNames - removed_systs}

print("Combination of", " ".join(args))
print("imax %d number of bins" % len(bins))
print("jmax %d number of processes minus 1" % (len(signals) + len(backgrounds) - 1))
Expand Down
Loading