Test buildx addition to multistage docker build action#26
Open
bquan0 wants to merge 11 commits into
Open
Conversation
Pull Request Test Coverage Report for Build 4452483034Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Member
|
Thanks @bquan0 - great to see this working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following this conversation, I tried out a version of the Firehed multistage docker build action that uses buildx. I set up the
Dockerfileto have stages 1, 2a, 2b, 3a, and 3b, where 2a and 3a depend on 1, and 2b and 3b depend on 2a and 3a respectively. The action seems to have the key buildx functionalities such as:Overall, I think the changes to the multistage action to make it use buildx are working properly.