Add first-seen and last-seen DNS history#4
Open
nexiumbiz-debug wants to merge 2 commits into
Open
Conversation
Author
|
Just checking whether this is still useful for the first-seen/last-seen bounty. The PR is mergeable from GitHub's side, and I can adjust the JSON shape or flag behavior if you'd prefer it closer to the wording in #1. I haven't put payout details in the public thread, but can provide them privately if this is selected. |
Author
|
I pushed a small follow-up at 4b6fb4c while rechecking the history comparison path. It replaces the two invalid binary_search calls with direct DNS record matching, so the first-seen/last-seen comparison does not depend on a strict ordering comparator that was not actually strict. The branch is still clean and mergeable from GitHub's side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--fs/--first-seenfor first-seen records--ls/--last-seen-daysfor records missing for at least N days--lsd/--last-seen-datefor records missing since a US-formatted cutoff dateNotes
This keeps older JSON input compatible by reading legacy
first_seen/last_seenkeys too, while writing the requestedfirst-seen/last-seenkeys going forward.For the bounty payout: I am not posting payment details publicly. If this PR is selected, payout details can be provided privately through the maintainer's preferred trusted channel.
Validation
git diff --checkNot run locally: build/tests. This Windows environment does not currently have
cmake,cl,g++, orclang++available on PATH.Closes #1