provides a flexible orderable plugins render_filename with entrypoints#59
Open
jpcw wants to merge 1 commit intocollective:masterfrom
Open
provides a flexible orderable plugins render_filename with entrypoints#59jpcw wants to merge 1 commit intocollective:masterfrom
jpcw wants to merge 1 commit intocollective:masterfrom
Conversation
Member
|
Is there a reason you didn't implement this as another hook? What is the different between a hook and a plugin? |
Member
Author
|
the reason is there is behavior could be : the lookup on hook could be in this order :
It will be more flexible :
What do you think about this design ? |
Member
|
@domenkozar Should this be closed ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flexible orderable plugin system with entrypoints to extend or override render_filename. Multi-registration available, specific target callable with -r, --rdr-fname-plugin-target cli option.
Long version here : https://github.com/jpcw/mr.bob/blob/03aecc4d16c54fa0964544a978128223d7d7d345/docs/source/pluginauthor.rst