Skip to content

Issue 1031 unionBySorted API #1415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rnjtranjan wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Issue 1031 unionBySorted API #1415

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7162f6a
Implement unionBySorted API
rnjtranjan Jan 6, 2022
f1feb80
Add bench mark for unionBySorted
rnjtranjan Mar 6, 2022
21974e1
Add extra-source-files
rnjtranjan Mar 6, 2022
75cf074
Fix hlint
rnjtranjan Mar 6, 2022
15964e8
move test cases to Prelude.Top
rnjtranjan Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions benchmark/Streamly/Benchmark/Prelude/Serial/NestedStream.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,10 @@ o_n_heap_buffering value =
$ joinWith Internal.intersectBy sqrtVal
, benchIOSrc1 "intersectBySorted"
$ joinMapWith (Internal.intersectBySorted compare) halfVal
, benchIOSrc1 "unionBy (sqrtVal)"
$ joinWith Internal.unionBy sqrtVal
, benchIOSrc1 "unionBySorted"
$ joinMapWith (Internal.unionBySorted compare) halfVal
]
]

Expand Down
13 changes: 8 additions & 5 deletions src/Streamly/Internal/Data/Stream/IsStream/Top.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ module Streamly.Internal.Data.Stream.IsStream.Top
, differenceBy
, mergeDifferenceBy
, unionBy
, mergeUnionBy
, unionBySorted

-- ** Join operations
, crossJoin
Expand Down Expand Up @@ -680,8 +680,11 @@ unionBy eq s1 s2 =
--
-- Space: O(1)
--
-- /Unimplemented/
{-# INLINE mergeUnionBy #-}
mergeUnionBy :: -- (IsStream t, Monad m) =>
-- /Pre-release/
{-# INLINE unionBySorted #-}
unionBySorted :: (IsStream t, MonadAsync m, Ord a) =>
(a -> a -> Ordering) -> t m a -> t m a -> t m a
mergeUnionBy _eq _s1 _s2 = undefined
unionBySorted cmp s1 =
IsStream.fromStreamD
. StreamD.unionBySorted cmp (IsStream.toStreamD s1)
. IsStream.toStreamD
Loading