apr-util: conan v2 support#16142
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
83a7504 to
12ef937
Compare
This comment has been minimized.
This comment has been minimized.
687a9e6 to
3b32138
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Hooks produced the following warnings for commit 3b32138apr-util/1.6.1 |
This comment has been minimized.
This comment has been minimized.
toge
previously approved these changes
Feb 23, 2023
This comment has been minimized.
This comment has been minimized.
3 tasks
Contributor
Author
@danimtb @uilianries would it be possible to generate apr packages please? |
This comment has been minimized.
This comment has been minimized.
3 tasks
Contributor
Author
|
Converted to draft until #16844 merged. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
I don't understand, libiconv is in requirements of apr-util. Another occurrence of conan-io/conan#13560? |
SpaceIm
commented
Apr 12, 2023
This comment has been minimized.
This comment has been minimized.
Contributor
|
Good callout my brain rushed and that was not a good comment :) we should know when and why to remove it in the future this way 🤞 |
Contributor
|
And sorry for commit to you PR, I totally thought this was toge's 😖 did not mean to do that again 🙊 |
Contributor
Conan v1 pipeline ✔️All green in build 15 (
Conan v2 pipeline (informative, not required for merge) ✔️
All green in build 16 (
|
prince-chrismc
approved these changes
Apr 13, 2023
SSE4
approved these changes
Apr 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specify library name and version: lib/1.0