fix: preserve metric snapshots when async metric tasks fail in indicator#2560
Open
aerosta wants to merge 1 commit intoconfident-ai:mainfrom
Open
fix: preserve metric snapshots when async metric tasks fail in indicator#2560aerosta wants to merge 1 commit intoconfident-ai:mainfrom
aerosta wants to merge 1 commit intoconfident-ai:mainfrom
Conversation
|
@aerosta is attempting to deploy a commit to the Confident AI Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
measure_metrics_with_indicatorused bareasyncio.gather(*tasks). If one metric raises an exception, sibling metric tasks could be canceled before completing. The caller then snapshots the metric state infinally, which could leave unfinished metrics withNonevalues.This change uses
return_exceptions=True, waits for all metric tasks to finish, and re-raises the first exception. This preserves existing error propagation while ensuring metric snapshots reflect the final task state.Context
PRs #2136 and #2247 applied the same pattern in
execute.py, but the two gather calls inindicator.pywere still using bareasyncio.gather(...). This change closes that remaining gap.Related: #2128, #2298
Changes
wait_for_metric_tasksindeepeval/metrics/indicator.pymeasure_metrics_with_indicator