Skip to content

fix: add accessible labels to sidebar controls #12327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danyalahmed1995 wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −0
Open

fix: add accessible labels to sidebar controls #12327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
001a084
fix: add accessible labels to sidebar controls
danyalahmed1995 May 7, 2026
0b3ac42
fix: label chat input for screen readers
danyalahmed1995 May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions gui/src/components/find/FindWidget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,8 @@ export const useFindWidget = (
<HeaderButton
inverted={false}
onClick={() => setOpen(false)}
aria-label="Close find widget"
title="Close find widget"
className="focus:ring"
>
<XMarkIcon className="h-4 w-4" />
Expand Down
2 changes: 2 additions & 0 deletions gui/src/components/gui/HeaderButtonWithToolTip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ const HeaderButtonWithToolTip = React.forwardRef<
disabled={props.disabled}
onClick={props.onClick}
onKeyDown={props.onKeyDown}
aria-label={props.text}
title={props.text}
className={props.className}
style={props.style}
ref={ref}
Expand Down
2 changes: 2 additions & 0 deletions gui/src/components/mainInput/InputToolbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,8 @@ function InputToolbar(props: InputToolbarProps) {
variant={props.isMainInput ? "primary" : "secondary"}
size="sm"
data-testid="submit-input-button"
aria-label="Send message"
title="Send message"
onClick={async (e) => {
if (props.onEnter) {
props.onEnter({
Expand Down
1 change: 1 addition & 0 deletions gui/src/components/mainInput/TipTapEditor/utils/editorConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,7 @@ export function createEditorConfig(options: {
"data-testid": props.isMainInput
? "editor-input-main"
: `editor-input-${props.inputId}`,
...(props.isMainInput ? { "aria-label": "Chat message input" } : {}),
class: "ProseMirror outline-none overflow-hidden",
style: `font-size: ${getFontSize()}px;`,
},
Expand Down
4 changes: 4 additions & 0 deletions gui/src/components/modelSelection/ModelSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,8 @@ function ModelOption({
size="sm"
className="text-description-muted hover:enabled:text-foreground my-0 h-4 w-4 p-0 opacity-0 transition-opacity group-hover:opacity-100"
onClick={handleConfigureClick}
aria-label={`Configure ${option.title}`}
title={`Configure ${option.title}`}
>
<Cog6ToothIcon className="h-3.5 w-3.5" />
</Button>
Expand Down Expand Up @@ -271,6 +273,8 @@ function ModelSelect() {
variant="ghost"
size="sm"
className="my-0 h-5 w-5 p-0"
aria-label="Configure models"
title="Configure models"
>
<Cog6ToothIcon className="text-description h-3.5 w-3.5" />
</Button>
Expand Down
Loading