在 /src/modules/plugin/hooks/upload/index.ts 文件中发现存储型XSS漏洞。该漏洞源于在使用key定义文件名时完全没有对文件后缀进行校验,可能导致恶意用户上传包含脚本的文件,从而引发XSS攻击。#231
Open
dogdogcan wants to merge 2 commits intocool-team-official:8.xfrom
Open
Conversation
added 2 commits
January 12, 2026 18:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. 添加文件扩展名白名单验证
在
upload/index.ts文件中添加了validateFileExtension方法,用于验证文件扩展名是否在配置的白名单中。2. 更新配置文件
在
config/config.default.ts中设置了默认的文件扩展名白名单.3. 在所有上传方法中增加验证
在以下三个关键方法中增加了扩展名验证:
downAndUpload: 下载并上传文件uploadWithKey: 指定Key上传文件upload: 通用文件上传