Skip to content

Fix cast_to_bool to treat whitespace-only strings as False #2462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
developreiloyo wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix cast_to_bool to treat whitespace-only strings as False #2462

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0335be7
fix: treat whitespace-only strings as false in cast_to_bool
developreiloyo Jan 19, 2026
06a1fdc
Move whitespace-only string test to test_tools.py
developreiloyo Jan 23, 2026
3004d38
Fix cast_to_bool to treat whitespace-only strings as False
developreiloyo Jan 23, 2026
d90d6ef
Apply suggestion from @sisp: handle whitespace-only strings upfront
developreiloyo Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions copier/_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,11 @@ def cast_to_bool(value: Any) -> bool:
# Assume it's a number
with suppress(TypeError, ValueError):
return bool(float(value))

# Treat whitespace-only string as False
if isinstance(value,str) and not value.strip():
Copy link
Copy Markdown
Member

@sisp sisp Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Treat whitespace-only string as False
if isinstance(value,str) and not value.strip():
# Treat whitespace-only string as False
if isinstance(value, str) and not value.strip():

return False

# Assume it's a string
with suppress(AttributeError):
lower = value.lower()
Expand Down
8 changes: 8 additions & 0 deletions tests/test_cast_to_bool.py
View file
Open in desktop
Comment thread
developreiloyo marked this conversation as resolved.
Outdated
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
from copier._tools import cast_to_bool


def test_cast_to_bool_whitespace_only_strings_are_false() -> None:
assert cast_to_bool("") is False
assert cast_to_bool(" ") is False
assert cast_to_bool("\n") is False
assert cast_to_bool(" \n\t") is False