[8.0] Make shopifyId and shopifyGid consistent across the system #221
Open
nfourtythree wants to merge 6 commits into
Open
[8.0] Make shopifyId and shopifyGid consistent across the system #221nfourtythree wants to merge 6 commits into
shopifyId and shopifyGid consistent across the system #221nfourtythree wants to merge 6 commits into
Conversation
# Conflicts: # CHANGELOG-WIP.md
This reverts commit 42d0c30.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The plugin previously used the term "Shopify ID" inconsistently, sometimes referring to the full GID string (
gid://shopify/Product/123456789), sometimes the numeric ID at the end of it. This PR makes that distinction explicit and consistent throughout.shopify_datatable'sshopifyIdcolumn has been renamed toshopifyGid. A new generatedshopifyIdcolumn containing the numeric ID (the last segment of the GID) has been added.shopify_bulkoperationstable'sshopifyIdcolumn has been renamed toshopifyGid.craft\shopify\models\Variant::$shopifyIdnow consistently holds the numeric Shopify ID. The full GID is now available via the new$shopifyGidproperty.craft\shopify\models\BulkOperation::$shopifyIdhas been replaced with$shopifyGid.*ByShopifyGid()methods have been added toProductsandBulkOperationsservices. The old*ByShopifyId()methods are deprecated and now delegate to their GID equivalents.