Send static files as chunks using IO::Handle.Supply#106
Open
lukasvalle wants to merge 3 commits into
Open
Conversation
…ould reduce memory usage when serving large files. Using Supply is a common pattern in cro in general. The rakudo default size makes the downloads a lot slower than server it from memory. 1MB is better. But what would be a sensible size for the chunks?
Contributor
|
@lukasvalle - hi ... there is now some baseline attention on Cro and I just came across your PR. To proceed, since the PR is now ~6 years old, please can you close this one, sync your fork, reapply your code over the interim changes, retest and resubmit? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intention of this PR is to show, that
cro-httpand theIO::Handle.Supplycore functionality would work nice together to implement something similar to sendfile_max_chunk in nginx to reduce memory consumption when delivering large files.This PR includes:
chunk_sizefor the static subcontent_lengthforSupply BodySerializerand the Routercontentmethod to set the content_length header field for chunk deliverd content