Add a maximum backup quantity setting and update the backup management logic to adhere to this limit#147
Open
Kainblake wants to merge 1 commit intocrschnick:masterfrom
Open
Conversation
…t logic to adhere to this limit
Owner
|
So ideally such a timestamp would be tracked in https://github.com/crschnick/pdx_unlimiter/blob/master/pdxu-app/src/main/java/com/crschnick/pdxu/app/savegame/SavegameEntry.java The ConfigHelper is the wrong place for that. |
Owner
|
Technically, we already have timestamps as the save files created by a SavegameEntry already do have a modified time on the local disk. So it I would be mainly a matter of deleting the oldest ones on import |
Owner
|
I can look into this properly when I find some time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.