feat(tests): add vitest test suite#420
Open
csandman wants to merge 5 commits into
Open
Conversation
Chakra v2's Select theme spreads `selectStyles.icon` onto the dropdown indicator container, which includes `pointerEvents: "none"` (needed in the native <select> to pass clicks through to the underlying element). That value has no purpose here and blocked userEvent from interacting with the indicator in tests. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Ports the react-select upstream test suite and adds chakra-specific tests covering size, variant, isInvalid, isReadOnly, chakraStyles, tagColorScheme, selectedOptionStyle, selectedOptionColorScheme, focusBorderColor, and the useChakraSelectProps hook. Adds vitest + @testing-library/* infrastructure, oxlint vitest plugin rules, and a dedicated test.yml CI workflow. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- lintstagedrc: filter src/tests/ before invoking oxlint to prevent "No files found" failure on test-only commits - oxfmtrc: ignore codemod test fixtures - CONTRIBUTING: add Tests section and pnpm test to PR checklist - publish workflow: run pnpm test before publishing - lint workflow: add pnpm lint:publish to build step Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
commit: |
📊 Package size report 0.2%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
react-selectupstream test suite (select,async-select,creatable-select,async-creatable-select,state-managed-select) adapted for Chakra v2 and vitestchakra-specific.test.tsxcoveringsize,variant,isInvalid,isReadOnly,isDisabled,chakraStyles,tagColorScheme,selectedOptionStyle,selectedOptionColorScheme,focusBorderColor, anduseChakraSelectProps@testing-library/reactinfrastructure (vitest.config.ts,src/tests/setup.ts,src/tests/render.tsx,src/tests/cases.ts,src/tests/constants.ts)pointerEvents: "none"on theDropdownIndicatorcontainer — inherited from Chakra v2's native Select icon theme, it had no purpose here and blocked pointer interactionmaintest.ymlCI workflow (Node 20 & 24 matrix)main: lint-staged test-file filter, oxfmt ignore patterns,CONTRIBUTING.mdTests section,pnpm teststep in publish workflow,lint:publishin lint workflowTest plan
pnpm testpasses (272 tests, 4 skipped)pnpm lintpasses with no new warnings🤖 Generated with Claude Code