Skip to content

Senator Roster Name Links Lead to a 404#173

Open
calebyhan wants to merge 1 commit into
mainfrom
160/senator-roster-links-404
Open

Senator Roster Name Links Lead to a 404#173
calebyhan wants to merge 1 commit into
mainfrom
160/senator-roster-links-404

Conversation

@calebyhan

Copy link
Copy Markdown
Contributor

On the senator roster page (/senators/roster), each senator's name is a link to /senators/[id]. No page route exists at that path — Next.js has no app/senators/[id]/page.tsx file — so every link results in a 404.

Changes:

  • Spinner
  • Better validation

Closes #160

@github-actions

Copy link
Copy Markdown

Test Results

570 tests  ±0   570 ✅ ±0   49s ⏱️ -1s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 2705c9f. ± Comparison against base commit 91e72e1.

@MasonMines2006 MasonMines2006 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Senator Roster Name Links Lead to a 404

2 participants