fix: add a test to check for circle ring closure#290
Open
llamington wants to merge 1 commit intod3:mainfrom
Open
fix: add a test to check for circle ring closure#290llamington wants to merge 1 commit intod3:mainfrom
llamington wants to merge 1 commit intod3:mainfrom
Conversation
Member
|
Upgrading the test is not enough; we'll want to add a test for the case that breaks, and fix the generator: Line 20 in 8c53a90 (this should probably store the starting point and repeat it at the end). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test to satisfy #289