Skip to content

fix: add a test to check for circle ring closure#290

Open
llamington wants to merge 1 commit intod3:mainfrom
llamington:main
Open

fix: add a test to check for circle ring closure#290
llamington wants to merge 1 commit intod3:mainfrom
llamington:main

Conversation

@llamington
Copy link
Copy Markdown

Adds a test to satisfy #289

@Fil
Copy link
Copy Markdown
Member

Fil commented Jul 2, 2024

Upgrading the test is not enough; we'll want to add a test for the case that breaks, and fix the generator:

for (var point, t = t0; direction > 0 ? t > t1 : t < t1; t -= step) {

(this should probably store the starting point and repeat it at the end).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants