Skip to content

DAOS-19116 object: do not log IO RPC DER_TIMEDOUT as ERROR #18509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nasf-Fan wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −8
Open

DAOS-19116 object: do not log IO RPC DER_TIMEDOUT as ERROR #18509

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/object/cli_shard.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -787,14 +787,14 @@ dc_rw_cb(tse_task_t *task, void *arg)
* If any failure happens inside Cart, let's reset failure to
* TIMEDOUT, so the upper layer can retry.
*/
D_ERROR(DF_UOID
" (%s) RPC %p (%d) to %d/%d, flags %lx/%x, task %p failed, %s, TX " DF_DTI
": " DF_RC "\n",
DP_UOID(orw->orw_oid), is_ec_obj ? "EC" : "non-EC", rw_args->rpc, opc,
rw_args->rpc->cr_ep.ep_rank, rw_args->rpc->cr_ep.ep_tag,
(unsigned long)orw->orw_api_flags, orw->orw_flags, task,
orw->orw_bulks.ca_arrays || orw->orw_bulks.ca_count ? "DMA" : "non-DMA",
DP_DTI(&orw->orw_dti), DP_RC(ret));
DL_CDEBUG(ret != -DER_TIMEDOUT, DLOG_ERR, DB_IO, ret,

@liuxuezhao liuxuezhao Jun 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

timeout looks not a normal case, if don't want to log it as ERR, maybe INFO is fine?

@wangshilong wangshilong Jun 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably only ERR/WARN if this is retried IO and it timeout again? sometimes it indeed indicate something wrong in the server.

DF_UOID " (%s) RPC %p (%d) "
" to %d/%d, flags %lx/%x, task %p failed, %s, TX " DF_DTI,
DP_UOID(orw->orw_oid), is_ec_obj ? "EC" : "non-EC", rw_args->rpc, opc,
rw_args->rpc->cr_ep.ep_rank, rw_args->rpc->cr_ep.ep_tag,
(unsigned long)orw->orw_api_flags, orw->orw_flags, task,
orw->orw_bulks.ca_arrays || orw->orw_bulks.ca_count ? "DMA" : "non-DMA",
DP_DTI(&orw->orw_dti));

D_GOTO(out, ret);
}
Expand Down
Loading