Skip to content

DAOS-19226 cart: primary group incorrectly initialized on clients #18534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
frostedcmos wants to merge 3 commits into
base: master
Choose a base branch
from
Open

DAOS-19226 cart: primary group incorrectly initialized on clients #18534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62b7e1c
DAOS-19226 cart: primary group incorrectly initialized on clients
frostedcmos Jun 24, 2026
5a93a9c
- Some clients were incorrectly calling crt_group_rank() which
frostedcmos Jun 24, 2026
c0f80b4
- only call crt_group_rank() on server side
frostedcmos Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions src/cart/crt_group.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1471,14 +1471,12 @@ crt_primary_grp_init(crt_group_id_t grpid)
{
struct crt_grp_gdata *grp_gdata;
struct crt_grp_priv *grp_priv = NULL;
crt_group_id_t pri_grpid;
bool is_service;
crt_group_id_t pri_grpid;
int rc = 0;

grp_gdata = crt_gdata.cg_grp;
D_ASSERT(grp_gdata != NULL);

is_service = crt_is_service();
pri_grpid = (grpid != NULL) ? grpid : CRT_DEFAULT_GRPID;

rc = crt_grp_priv_create(&grp_priv, pri_grpid, true);
Expand All @@ -1488,13 +1486,8 @@ crt_primary_grp_init(crt_group_id_t grpid)
}
D_ASSERT(grp_priv != NULL);

if (is_service) {
grp_priv->gp_self = CRT_NO_RANK;
grp_priv->gp_size = 0;
} else {
grp_priv->gp_size = 1;
grp_priv->gp_self = 0;
}
grp_priv->gp_self = CRT_NO_RANK;
grp_priv->gp_size = 0;

rc = grp_priv_init_membs(grp_priv, grp_priv->gp_size);
if (rc != 0) {
Expand Down
4 changes: 4 additions & 0 deletions src/cart/crt_rpc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1180,6 +1180,10 @@ crt_req_is_self(struct crt_rpc_priv *rpc_priv)
bool same_rank;

D_ASSERT(rpc_priv != NULL);

if (!crt_is_service())
return false;

grp_priv_self = crt_grp_pub2priv(NULL);
tgt_ep = &rpc_priv->crp_pub.cr_ep;
same_group = (tgt_ep->ep_grp == NULL) ||
Expand Down
3 changes: 0 additions & 3 deletions src/tests/ftest/cart/test_ep_cred_client.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,6 @@ test_run()
rc = sem_init(&test.tg_queue_front_token, 0, 0);
D_ASSERTF(rc == 0, "sem_init() failed.\n");

rc = crt_group_rank(NULL, &test.tg_my_rank);
D_ASSERTF(rc == 0, "crt_group_rank() failed. rc: %d\n", rc);

rc = crt_proto_register(&my_proto_fmt_0);
D_ASSERTF(rc == 0, "registration failed with rc: %d\n", rc);

Expand Down
3 changes: 0 additions & 3 deletions src/tests/ftest/cart/test_multisend_client.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,6 @@ test_run()
rc = sem_init(&test.tg_token_to_proceed, 0, 0);
D_ASSERTF(rc == 0, "sem_init() failed.\n");

rc = crt_group_rank(NULL, &test.tg_my_rank);
D_ASSERTF(rc == 0, "crt_group_rank() failed. rc: %d\n", rc);

rc = crt_proto_register(&my_proto_fmt);
D_ASSERTF(rc == 0, "crt_proto_register() failed. rc: %d\n", rc);

Expand Down
3 changes: 0 additions & 3 deletions src/tests/ftest/cart/test_no_timeout.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,6 @@ test_run(void)
rc = sem_init(&test_g.t_token_to_proceed, 0, 0);
D_ASSERTF(rc == 0, "sem_init() failed.\n");

rc = crt_group_rank(NULL, &test_g.t_my_rank);
D_ASSERTF(rc == 0, "crt_group_rank() failed. rc: %d\n", rc);

/* register RPCs */
rc = crt_proto_register(&my_proto_fmt_test_group1);
D_ASSERTF(rc == 0, "crt_proto_register() failed. rc: %d\n", rc);
Expand Down
5 changes: 1 addition & 4 deletions src/tests/ftest/cart/test_proto_client.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
* (C) Copyright 2018-2024 Intel Corporation.
* (C) Copyright 2025 Hewlett Packard Enterprise Development LP
* (C) Copyright 2025-2026 Hewlett Packard Enterprise Development LP
*
* SPDX-License-Identifier: BSD-2-Clause-Patent
*/
Expand Down Expand Up @@ -87,9 +87,6 @@ test_run()
rc = sem_init(&test.tg_token_to_proceed, 0, 0);
D_ASSERTF(rc == 0, "sem_init() failed.\n");

rc = crt_group_rank(NULL, &test.tg_my_rank);
D_ASSERTF(rc == 0, "crt_group_rank() failed. rc: %d\n", rc);

switch (test.tg_num_proto) {
case 4:
rc = crt_proto_register(&my_proto_fmt_3);
Expand Down
7 changes: 5 additions & 2 deletions src/tests/ftest/cart/test_rpc_error.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/*
* (C) Copyright 2017-2021 Intel Corporation.
* (C) Copyright 2026 Hewlett Packard Enterprise Development LP
*
* SPDX-License-Identifier: BSD-2-Clause-Patent
*/
Expand Down Expand Up @@ -204,8 +205,10 @@ rpc_err_init(void)
rc = crt_init(rpc_err.re_local_group_name, flag);
D_ASSERTF(rc == 0, "crt_init() failed, rc: %d\n", rc);

rc = crt_group_rank(NULL, &rpc_err.re_my_rank);
D_ASSERTF(rc == 0, "crt_group_rank() failed, rc: %d\n", rc);
if (rpc_err.re_is_service) {
rc = crt_group_rank(NULL, &rpc_err.re_my_rank);
D_ASSERTF(rc == 0, "crt_group_rank() failed, rc: %d\n", rc);
}

rc = crt_context_create(&rpc_err.re_crt_ctx);
D_ASSERTF(rc == 0, "crt_context_create() failed. rc: %d\n", rc);
Expand Down
Loading