-
Notifications
You must be signed in to change notification settings - Fork 0
feat(sdcard): add SD card storage capacity query (closes #206) #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tylerkron
wants to merge
5
commits into
main
Choose a base branch
from
claude/nifty-hypatia-514105
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+467
−0
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3f18ab3
feat(sdcard): add SD card storage capacity query (closes #206)
tylerkron 96bbf4e
Merge branch 'main' into claude/nifty-hypatia-514105
tylerkron 62b8def
fix(sdcard): refuse storage query during logging; short-circuit no-ca…
tylerkron c1e24ee
Merge branch 'main' into claude/nifty-hypatia-514105
tylerkron 73db0ff
Merge branch 'main' into claude/nifty-hypatia-514105
cptkoolbeenz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
101 changes: 101 additions & 0 deletions
101
src/Daqifi.Core.Tests/Device/SdCard/SdCardSpaceParserTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| using Daqifi.Core.Device.SdCard; | ||
|
|
||
| namespace Daqifi.Core.Tests.Device.SdCard; | ||
|
|
||
| public class SdCardSpaceParserTests | ||
| { | ||
| [Fact] | ||
| public void TryParse_ValidResponse_ReturnsStorageInfo() | ||
| { | ||
| Assert.True(SdCardSpaceParser.TryParse("1048576000,2097152000", out var result)); | ||
| Assert.NotNull(result); | ||
| Assert.Equal(1_048_576_000L, result.FreeBytes); | ||
| Assert.Equal(2_097_152_000L, result.TotalBytes); | ||
| Assert.Equal(1_048_576_000L, result.UsedBytes); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void TryParse_WithSurroundingWhitespace_ReturnsStorageInfo() | ||
| { | ||
| Assert.True(SdCardSpaceParser.TryParse(" 100 , 500 ", out var result)); | ||
| Assert.NotNull(result); | ||
| Assert.Equal(100L, result.FreeBytes); | ||
| Assert.Equal(500L, result.TotalBytes); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void TryParse_FullCard_ReturnsZeroFree() | ||
| { | ||
| Assert.True(SdCardSpaceParser.TryParse("0,1000000", out var result)); | ||
| Assert.NotNull(result); | ||
| Assert.Equal(0L, result.FreeBytes); | ||
| Assert.Equal(1_000_000L, result.TotalBytes); | ||
| Assert.Equal(1_000_000L, result.UsedBytes); | ||
| } | ||
|
|
||
| [Theory] | ||
| [InlineData(null)] | ||
| [InlineData("")] | ||
| [InlineData(" ")] | ||
| public void TryParse_NullOrWhitespace_ReturnsFalse(string? input) | ||
| { | ||
| Assert.False(SdCardSpaceParser.TryParse(input, out var result)); | ||
| Assert.Null(result); | ||
| } | ||
|
|
||
| [Theory] | ||
| [InlineData("1048576000")] // no comma | ||
| [InlineData(",2097152000")] // missing free | ||
| [InlineData("1048576000,")] // missing total | ||
| [InlineData("abc,2097152000")] // non-numeric free | ||
| [InlineData("1048576000,xyz")] // non-numeric total | ||
| [InlineData("-1,2097152000")] // negative free | ||
| [InlineData("1048576000,-1")] // negative total | ||
| [InlineData("5000,1000")] // free > total (corrupt metadata) | ||
| [InlineData("**ERROR: -200, \"Execution error\"")] // SCPI error | ||
| public void TryParse_Malformed_ReturnsFalse(string input) | ||
| { | ||
| Assert.False(SdCardSpaceParser.TryParse(input, out var result)); | ||
| Assert.Null(result); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void TryParseLines_FindsFirstValidLine() | ||
| { | ||
| var lines = new[] | ||
| { | ||
| "", | ||
| "some preamble", | ||
| "1024,4096", | ||
| "trailing text" | ||
| }; | ||
|
|
||
| Assert.True(SdCardSpaceParser.TryParseLines(lines, out var result)); | ||
| Assert.NotNull(result); | ||
| Assert.Equal(1024L, result.FreeBytes); | ||
| Assert.Equal(4096L, result.TotalBytes); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void TryParseLines_NoValidLines_ReturnsFalse() | ||
| { | ||
| var lines = new[] { "", "garbage", "**ERROR: -200" }; | ||
|
|
||
| Assert.False(SdCardSpaceParser.TryParseLines(lines, out var result)); | ||
| Assert.Null(result); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void TryParseLines_EmptySequence_ReturnsFalse() | ||
| { | ||
| Assert.False(SdCardSpaceParser.TryParseLines([], out var result)); | ||
| Assert.Null(result); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void UsedBytes_ComputesDifference() | ||
| { | ||
| var info = new SdCardStorageInfo(FreeBytes: 300, TotalBytes: 1000); | ||
| Assert.Equal(700L, info.UsedBytes); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.