Skip to content

Commit f57c010

Browse files
committed
Refactoring script for ecr AWS_REGION
1 parent 57f0960 commit f57c010

4 files changed

Lines changed: 12 additions & 8 deletions

File tree

compose/ecr-build.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88
set -e
99

1010
export AWS_ACCOUNT_ID=$1
11-
export CI_REGISTRY="${AWS_ACCOUNT_ID}.dkr.ecr.ap-southeast-1.amazonaws.com"
11+
export AWS_REGION="ap-southeast-1"
12+
export CI_REGISTRY="$AWS_ACCOUNT_ID.dkr.ecr.$AWS_REGION.amazonaws.com"
1213
export CI_ECR_PATH=$3
1314

1415
export IMAGE="$CI_REGISTRY/$CI_ECR_PATH"

compose/ecr-pull.sh

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88
set -e
99

1010
export AWS_ACCOUNT_ID=$1
11-
export CI_REGISTRY="${AWS_ACCOUNT_ID}.dkr.ecr.ap-southeast-1.amazonaws.com"
11+
export AWS_REGION="ap-southeast-1"
12+
export CI_REGISTRY="$AWS_ACCOUNT_ID.dkr.ecr.$AWS_REGION.amazonaws.com"
1213
export CI_ECR_PATH=$2
1314

1415
export IMAGE="$CI_REGISTRY/$CI_ECR_PATH"
@@ -22,8 +23,8 @@ login_ecr() {
2223
echo "============="
2324
echo " Login ECR "
2425
echo "============="
25-
PASSWORD=$(aws ecr get-login-password --region ap-southeast-1)
26-
echo $PASSWORD | docker login --username AWS --password-stdin ${AWS_ACCOUNT_ID}.dkr.ecr.ap-southeast-1.amazonaws.com
26+
PASSWORD=$(aws ecr get-login-password --region $AWS_REGION)
27+
echo $PASSWORD | docker login --username AWS --password-stdin $AWS_ACCOUNT_ID.dkr.ecr.$AWS_REGION.amazonaws.com
2728
echo '- DONE -'
2829
echo ''
2930
}

compose/ecr-push.sh

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88
set -e
99

1010
export AWS_ACCOUNT_ID=$1
11-
export CI_REGISTRY="${AWS_ACCOUNT_ID}.dkr.ecr.ap-southeast-1.amazonaws.com"
11+
export AWS_REGION="ap-southeast-1"
12+
export CI_REGISTRY="$AWS_ACCOUNT_ID.dkr.ecr.$AWS_REGION.amazonaws.com"
1213
export CI_ECR_PATH=$2
1314

1415
export IMAGE="$CI_REGISTRY/$CI_ECR_PATH"
@@ -17,8 +18,8 @@ login_ecr() {
1718
echo "============="
1819
echo " Login ECR "
1920
echo "============="
20-
PASSWORD=$(aws ecr get-login-password --region ap-southeast-1)
21-
echo $PASSWORD | docker login --username AWS --password-stdin ${AWS_ACCOUNT_ID}.dkr.ecr.ap-southeast-1.amazonaws.com
21+
PASSWORD=$(aws ecr get-login-password --region $AWS_REGION)
22+
echo $PASSWORD | docker login --username AWS --password-stdin $AWS_ACCOUNT_ID.dkr.ecr.$AWS_REGION.amazonaws.com
2223
echo '- DONE -'
2324
echo ''
2425
}

compose/ecr-tag.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88
set -e
99

1010
export AWS_ACCOUNT_ID=$1
11-
export CI_REGISTRY="${AWS_ACCOUNT_ID}.dkr.ecr.ap-southeast-1.amazonaws.com"
11+
export AWS_REGION="ap-southeast-1"
12+
export CI_REGISTRY="$AWS_ACCOUNT_ID.dkr.ecr.$AWS_REGION.amazonaws.com"
1213
export CI_ECR_PATH=$2
1314

1415
export IMAGE="$CI_REGISTRY/$CI_ECR_PATH"

0 commit comments

Comments
 (0)