[DEN-2026] add gold sponsor, fix logos #15891
+2
−0
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
|
Collaborator
There was a problem hiding this comment. You're missing a data file, please add a file in |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're missing a data file, please add a file in data/sponsors/nostarchpress.yml with the name, url and any other information you want or need
As you're the only event using this sponsor, it is fine to just change the logo, otherwise we would need a
oldandnewversion.This is mearly for information that I adding this second part, the first part is important to add a sponsor data file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@toshywoshy that file already exists in the PR I linked in the description:
The original logo name uploaded had camel case which was breaking the linter. When we renamed it, it removed the old one without adding it back with the new name so it was missing from the linked pr at the time of merge. We also added both sponsors as new in that same linked PR so there was no need to make an old/new version. This was mostly to fix a previous merge and to add a new sponsor to our page.