fix: track offline status even when iframes are focused#43
Merged
Conversation
kabaros
approved these changes
Apr 10, 2025
kabaros
left a comment
kabaros
left a comment
Collaborator
There was a problem hiding this comment.
tested and works as described
dhis2-bot
added a commit
that referenced
this pull request
Apr 10, 2025
## [1.7.4](v1.7.3...v1.7.4) (2025-04-10) ### Bug Fixes * track offline status even when iframes are focused ([#43](#43)) ([34a3ebe](34a3ebe))
Contributor
|
🎉 This PR is included in version 1.7.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DHIS2-19285
Uses a patch of
app-runtime, since the implementation there (dhis2/app-runtime#1411) should be considered there before generalizing to all apps.While an app is focused, visible, and inactive, this will result in some more pings being sent by the global shell than before. I don't think this is significant, because the number of pings is carefully managed to be low
offline-indicator.mov