Skip to content

fix: prevent duplicate overview map outline in splitmap download mode [DHIS2-21540]#3676

Merged
BRaimbault merged 5 commits into
fix/release-DHIS2-15884-19205-21540from
fix/DHIS2-21540
Jun 18, 2026
Merged

fix: prevent duplicate overview map outline in splitmap download mode [DHIS2-21540]#3676
BRaimbault merged 5 commits into
fix/release-DHIS2-15884-19205-21540from
fix/DHIS2-21540

Conversation

@BRaimbault

@BRaimbault BRaimbault commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Implements DHIS2-21540

Description

  • Replace useState with useRef for source ID guard to prevent duplicate outline layer on zoom/drag
  • Remove outline layer on unmount
  • Use DHIS2 theme colors for outline stroke on dark/light basemaps
  • Add getCssColor utility to src/util/colors.js
  • Mark Sentinel-2 EOX basemap as isDark: true
  • Fix crash on direct navigation to split-layer download URL

Quality checklist

Add N/A to items that are not applicable.

  • Dashboard tested N/A
  • Cypress and/or Jest tests added/updated N/A
  • Docs added N/A
  • d2-ci dependencies replaced N/A
  • Tester approved (@edoardo)

Screenshots

image image

@dhis2-bot

dhis2-bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed on https://pr-3676.maps.netlify.dhis2.org

@dhis2-bot dhis2-bot temporarily deployed to netlify June 16, 2026 12:38 Inactive
@BRaimbault BRaimbault marked this pull request as ready for review June 16, 2026 13:56
@dhis2-bot dhis2-bot temporarily deployed to netlify June 16, 2026 13:56 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify June 16, 2026 17:31 Inactive
@BRaimbault BRaimbault changed the base branch from master to fix/release-DHIS2-15884-19205-21540 June 18, 2026 12:32
@sonarqubecloud

Copy link
Copy Markdown

@dhis2-bot dhis2-bot temporarily deployed to netlify June 18, 2026 12:48 Inactive
@BRaimbault BRaimbault merged commit 0a98dbb into fix/release-DHIS2-15884-19205-21540 Jun 18, 2026
28 checks passed
@BRaimbault BRaimbault deleted the fix/DHIS2-21540 branch June 18, 2026 12:57
dhis2-bot added a commit that referenced this pull request Jun 18, 2026
## [101.13.1](v101.13.0...v101.13.1) (2026-06-18)

### Bug Fixes

* preserve program/enrollment period type on TE layer reload [DHIS2-19205] ([#3674](#3674)) ([59cd55d](59cd55d))
* prevent duplicate overview map outline in splitmap download mode [DHIS2-21540] ([#3676](#3676)) ([0a98dbb](0a98dbb))
* resize data table and map canvas continuously during drag [DHIS2-15884] ([#3675](#3675)) ([44bbd24](44bbd24))
@dhis2-bot

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 101.13.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants