Merge 'cython all the things' and 'allow -H for k > 32' code.#1626
Closed
ctb wants to merge 12 commits into
Closed
Merge 'cython all the things' and 'allow -H for k > 32' code.#1626ctb wants to merge 12 commits into
ctb wants to merge 12 commits into
Conversation
ctb
changed the title
Member
Author
|
This merge wasn't so bad... |
Member
|
It helps that I already did the horrible part :P
…On Fri, Feb 17, 2017 at 6:27 AM, C. Titus Brown ***@***.***> wrote:
This merge wasn't so bad...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1626 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACwxrdhQs5gnp10kDNgNJKYiPqTpVEavks5rda48gaJpZM4MEU2y>
.
--
Camille Scott
Graduate Group for Computer Science
Lab for Data Intensive Biology
University of California, Davis
camille.scott.w@gmail.com
|
Member
Author
|
we thank you for your sacrifice!
|
Member
|
We can close this right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge #1623 into #1595, as a trial.
make testDid it pass the tests?make clean diff-coverIf it introduces new functionality inscripts/is it tested?make format diff_pylint_report cppcheck doc pydocstyleIs it wellformatted?
additions are allowed without a major version increment. Changing file
formats also requires a major version number increment.
documented in
CHANGELOG.md? See keepachangelogfor more details.
changes were made?
tested for streaming IO?)