[MRG] Drop __future__ imports#1786
Merged
Merged
Conversation
Member
Author
|
I'll handle merging this back into #1774, including conflicts if there are any. |
Member
Author
|
Ready for review @ctb @luizirber @betatim! |
Codecov Report
@@ Coverage Diff @@
## master #1786 +/- ##
=========================================
- Coverage 0.06% 0.05% -0.02%
=========================================
Files 78 78
Lines 9792 9757 -35
Branches 2457 2457
=========================================
- Hits 6 5 -1
+ Misses 9786 9752 -34
Continue to review full report at Codecov.
|
betatim
approved these changes
Sep 14, 2017
Member
|
Before I hit merge, do you want to merge this into master or #1774? The PR says master but your comment makes me wonder. |
Member
Author
|
Definitely into master. It's a subset of changes from #1774, which I'm trying to break into smaller more manageable chunks. I'll resolve any conflicts on that branch that arise from merging this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we've dropped Python 2 support,
__future__imports are unnecessary. Aside from the Makefile, all changes to the code in this PR were made bygrep -vand shell for loops.NB: Splitting this out from #1774 to simplify code review.
make testDid it pass the tests?make clean diff-coverIf it introduces new functionality inscripts/is it tested?make format diff_pylint_report cppcheck doc pydocstyleIs it wellformatted?
documented in
CHANGELOG.md? See keepachangelogfor more details.