Accessibility/sr for error for autosuggest#2139
Merged
Merged
Conversation
aaschlote
reviewed
May 27, 2025
pgurusinga
reviewed
May 27, 2025
| <components.Input | ||
| // avoid to clear the previous auto suggestion input when press enter | ||
| // this cannot be tested, thus manually tested with device(s) | ||
| onKeyDown={(e) => { |
Member
There was a problem hiding this comment.
Can the testing library be used to test this behaviour?
pgurusinga
approved these changes
May 27, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fieldname and error were not read because of missing aria-describedby in the CustomInput. This solves the issue