Skip to content

[Draft] Address flaky tests #3754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
avazirna wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[Draft] Address flaky tests #3754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d340d76
CaseClaimTest.testCaseClaimByDifferentUser() - wait for case search r…
avazirna Jun 7, 2026
216ac7e
testLoginFlow_withoutInternet - Ensure Wi-Fi is disabled before login…
avazirna Jun 8, 2026
674cdda
testCannotSaveBlankSignatures() - sleep after returning from an exit …
avazirna Jun 10, 2026
2b79c62
Wait for overflow menu item to be rendered
avazirna Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/instrumentation-tests/src/org/commcare/androidTests/CaseClaimTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,11 @@
import static androidx.test.espresso.assertion.ViewAssertions.doesNotExist;
import static androidx.test.espresso.assertion.ViewAssertions.matches;
import static androidx.test.espresso.matcher.ViewMatchers.isDisplayed;
import static androidx.test.espresso.matcher.ViewMatchers.isRoot;
import static androidx.test.espresso.matcher.ViewMatchers.withClassName;
import static androidx.test.espresso.matcher.ViewMatchers.withId;
import static androidx.test.espresso.matcher.ViewMatchers.withText;
import static org.commcare.utils.InstrumentationUtility.waitForView;
import static org.hamcrest.Matchers.allOf;
import static org.hamcrest.Matchers.endsWith;

Expand Down Expand Up @@ -126,6 +128,8 @@ public void testCaseClaimByDifferentUser() {
.perform(click());

// Close the new case of cordelia with this user.
onView(withId(R.id.screen_entity_select_list))
.perform(waitForView(withText(name), 10000, true));
onView(withText(name))
.perform(click());
onView(withText("Continue"))
Expand Down
1 change: 1 addition & 0 deletions app/instrumentation-tests/src/org/commcare/androidTests/LoginTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ class LoginTest: BaseTest() {
InstrumentationUtility.logout()

// login offline with bad password
InstrumentationUtility.changeWifi(false)
InstrumentationUtility.login("user_with_no_data", "badpass")
onView(withText("Either the password you entered was incorrect, or CommCare couldn't reach the server"))
.check(matches(isDisplayed()))
Expand Down
2 changes: 2 additions & 0 deletions app/instrumentation-tests/src/org/commcare/androidTests/SignatureTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import org.commcare.annotations.BrowserstackTests
import org.commcare.utils.InstrumentationUtility
import org.commcare.views.DrawView
import org.commcare.dalvik.R
import org.commcare.utils.InstrumentationUtility.sleep
import org.commcare.utils.doesNotExist
import org.commcare.utils.isDisplayed
import org.hamcrest.Matchers
Expand Down Expand Up @@ -127,6 +128,7 @@ class SignatureTests: BaseTest() {
Espresso.pressBack()
withText(R.string.keep_changes).doesNotExist()
Espresso.pressBack()
sleep(1)
}

/**
Expand Down
1 change: 1 addition & 0 deletions app/instrumentation-tests/src/org/commcare/utils/InstrumentationUtility.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ object InstrumentationUtility {
// Click on About CommCare 4 times to become developer.
for (i in 0..3) {
openOptionsMenu()
onView(isRoot()).perform(waitForView(withText("About CommCare")))
onView(withText("About CommCare"))
.perform(click())
onView(withText(R.string.ok))
Expand Down
Loading