added natural image height and width without defined it with data-psw…#2048
Open
spoitler wants to merge 2 commits into
Open
added natural image height and width without defined it with data-psw…#2048spoitler wants to merge 2 commits into
spoitler wants to merge 2 commits into
Conversation
…p-width and data-pswp-height
Owner
|
I'm not sure that relying on thumbnail dimensions is a good idea, especially as a default behavior. The |
|
I think setting the default width and height is a good idea. Once the width and height preview is not set, there will be problems. Setting the default width and height can be used as a compatibility solution |
|
Yes, this is not a big problem. Both data-pswp-width and data-pswp-height can be dynamically assigned after the image is loaded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion référence : Photoswipe 5 without defining image width and height? #1988
The data-pswp-width and data-pswp-height still working, but now it is optional.
before
after