Fix #23084 - Interpolated expression errors show 'filename-mixin-N' p…#23085
Merged
thewilsonator merged 1 commit intodlang:masterfrom May 7, 2026
Merged
Fix #23084 - Interpolated expression errors show 'filename-mixin-N' p…#23085thewilsonator merged 1 commit intodlang:masterfrom
thewilsonator merged 1 commit intodlang:masterfrom
Conversation
…-N' pseudo-location Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
| } | ||
|
|
||
| extern(D) void appendInterpolatedPart(const(char)[] str) | ||
| extern(D) void appendInterpolatedPart(const(char)[] str, Loc loc) |
Contributor
There was a problem hiding this comment.
default argument of Loc.init?
Contributor
Author
There was a problem hiding this comment.
Claude initially did that, but that made it forget to support other interpolated strings than i"". The DMD best practices also says:
- Avoid the use of default parameters. Spell them out.
thewilsonator
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…seudo-location
Closes #23084