Skip to content

[automated] Merge branch 'main' => 'feature/net11-scouting'#19702

Open
github-actions[bot] wants to merge 21 commits intofeature/net11-scoutingfrom
merge/main-to-feature/net11-scouting
Open

[automated] Merge branch 'main' => 'feature/net11-scouting'#19702
github-actions[bot] wants to merge 21 commits intofeature/net11-scoutingfrom
merge/main-to-feature/net11-scouting

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented May 7, 2026

I detected changes in the main branch which have not been merged yet to feature/net11-scouting. I'm a robot and am configured to help you automatically keep feature/net11-scouting up to date, so I've opened this PR.

This PR merges commits made on main by the following committers:

  • T-Gro
  • abonie
  • majocha
  • dotnet-maestro[bot]
  • missymessa
  • dependabot[bot]
  • Copilot

Instructions for merging from UI

This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.

merge button instructions

If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.

Instructions for merging via command line

Run these commands to merge this pull request from the command line.

git fetch
git checkout main
git pull --ff-only
git checkout feature/net11-scouting
git pull --ff-only
git merge --no-ff main

# If there are merge conflicts, resolve them and then run git merge --continue to complete the merge
# Pushing the changes to the PR branch will re-trigger PR validation.
git push https://github.com/dotnet/fsharp HEAD:merge/main-to-feature/net11-scouting
or if you are using SSH
git push git@github.com:dotnet/fsharp HEAD:merge/main-to-feature/net11-scouting

After PR checks are complete push the branch

git push

Instructions for resolving conflicts

⚠️ If there are merge conflicts, you will need to resolve them manually before merging. You can do this using GitHub or using the command line.

Instructions for updating this pull request

Contributors to this repo have permission update this pull request by pushing to the branch 'merge/main-to-feature/net11-scouting'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.
The provided examples assume that the remote is named 'origin'. If you have a different remote name, please replace 'origin' with the name of your remote.

git fetch
git checkout -b merge/main-to-feature/net11-scouting origin/feature/net11-scouting
git pull https://github.com/dotnet/fsharp merge/main-to-feature/net11-scouting
(make changes)
git commit -m "Updated PR with my changes"
git push https://github.com/dotnet/fsharp HEAD:merge/main-to-feature/net11-scouting
or if you are using SSH
git fetch
git checkout -b merge/main-to-feature/net11-scouting origin/feature/net11-scouting
git pull git@github.com:dotnet/fsharp merge/main-to-feature/net11-scouting
(make changes)
git commit -m "Updated PR with my changes"
git push git@github.com:dotnet/fsharp HEAD:merge/main-to-feature/net11-scouting

Contact .NET Core Engineering (dotnet/dnceng) if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/main/.github/workflows/scripts/inter-branch-merge.ps1.

Copilot AI and others added 21 commits April 28, 2026 08:43
The auto-update workflow was failing with "protected files" error because
it tried to modify .github/agents/, .github/aw/, and .github/workflows/*.lock.yml
files without having them listed in allowed-files.

Add allowed-files patterns covering all files that gh aw upgrade/compile
can touch, and add protected-files: fallback-to-issue as safety net.

Agent-Logs-Url: https://github.com/dotnet/fsharp/sessions/59195935-8f4a-4404-a7cd-6f3dd8425890

Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>
…orkflow-auto-update-again

# Conflicts:
#	.github/workflows/aw-auto-update.lock.yml
…to-update-again

Add allowed-files to aw-auto-update for gh-aw managed files
…in scope (#19568)

* Initial plan

* Fix ICE in BuildDisposableCleanup when Dispose extension methods are in scope

Use AtMostOneResult to leverage existing intrinsic-over-extension priority in
AllMethInfosOfTypeInScope, matching how regular method calls resolve Dispose.

Agent-Logs-Url: https://github.com/dotnet/fsharp/sessions/ebba43f1-81b6-417c-9138-f5867056fd94

Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>
Co-authored-by: Tomas Grosup <Tomas.Grosup@gmail.com>
…en (#19484)

* Initial plan

* Fix internal error when using custom attribute with optional value type argument (fixes #8353)

Handle Const.Zero for all primitive value types in GenAttribArg, which is
used when [<Optional>] is specified without [<DefaultParameterValue>] on
attribute constructor parameters. Previously only System.Object, System.String,
and System.Type were handled, causing an internal error for bool, int, and
other value types.

Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/fsharp/sessions/6f81842d-a307-4b7e-9ef2-ffa78948f9c6

* Add comprehensive test coverage for all primitive value types in optional attribute args

Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/fsharp/sessions/6f81842d-a307-4b7e-9ef2-ffa78948f9c6

* Merge main, add release notes for #8353 fix

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>
Co-authored-by: Tomas Grosup <Tomas.Grosup@gmail.com>
Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…504.4 (#19678)

On relative base path root
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.8.0-1.26252.1 -> To Version 5.8.0-1.26254.4

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…19472)

* Fix #12796: handle arrays of user-defined types in custom attributes

Empty arrays of non-encodable types (classes, records, structs) in custom
attributes now compile successfully by encoding them as System.Object[] per
ECMA-335. Non-empty arrays of such types produce FS3887 instead of the
internal error FS0192.
* Add LabelOps agentic workflows

Two opt-in, label-gated workflows for automated PR maintenance:

- labelops-pr-maintenance: scheduled every 3h, iterates open PRs
  carrying AI-Auto-Resolve-Conflicts or AI-Auto-Resolve-CI, shuffles
  for fairness seeded by GITHUB_RUN_ID, caps at 5 PRs per run.
  Per PR: triages CI first (pr-build-status skill), resolves conflicts
  second. Small mechanical CI fixes applied in-place with local
  verification. Proven flakes (flaky-test-detector ≥3 PRs) are
  delegated to the spinoff workflow. Unfixable CI escalates by adding
  AI-needs-CI-fix-input with a repro + up to 3 options. Labels are
  sticky — agent never removes any label.

- labelops-flake-fix: workflow_dispatch-only spinoff, dispatched from
  the babysitter via safe-outputs.dispatch-workflow. Re-verifies the
  flake, reproduces with a 20-iteration loop, prefers determinism fix
  else quarantines. Scoped to tests/** and vsintegration/tests/**.

Both workflows use protected-files: fallback-to-issue to prevent any
.github/** modifications. Ship with schedule enabled; dry-run via
workflow_dispatch recommended before relying on scheduled runs.
…nts (#19668)

* Add skill-validation workflow for structural checks on skills and agents

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Fix skill-validator errors: rename skill dir, add agent name field

- Rename .github/skills/expert-review/ to reviewing-compiler-prs/ to match
  frontmatter name (validator requires directory/name match)
- Add missing name field to agentic-workflows.agent.md frontmatter

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Update dependencies from https://github.com/dotnet/roslyn build 20260505.3
On relative base path root
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.8.0-1.26254.4 -> To Version 5.8.0-1.26255.3

* Retrigger CI after transient agent failure

The IcedTasks_Test_Debug job was cancelled due to CI agent crash
(exit code -1073741502 / STATUS_DLL_INIT_FAILED). All other jobs passed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Update dependencies from https://github.com/dotnet/roslyn build 20260506.1
On relative base path root
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.8.0-1.26254.4 -> To Version 5.8.0-1.26256.1

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Update dependencies from https://github.com/dotnet/arcade build 20260505.9
On relative base path root
Microsoft.DotNet.Arcade.Sdk From Version 10.0.0-beta.26222.2 -> To Version 10.0.0-beta.26255.9

* Fix flaky AsyncMemoize test: wait for all terminal events before asserting

The 'Cancel running jobs with the same key' test was racy - it waited
only for the Finished event before asserting Canceled count == 10, but
Canceled events from background jobs could still be in-flight. Now waits
for all 11 terminal events (10 Canceled + 1 Finished) before asserting.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
….3 (#19695)

* Bump OpenTelemetry.Exporter.OpenTelemetryProtocol from 1.11.2 to 1.15.3

---
updated-dependencies:
- dependency-name: OpenTelemetry.Exporter.OpenTelemetryProtocol
  dependency-version: 1.15.3
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fix test scripts to use System.Memory 4.6.3 instead of 4.5.3

The neg107 and span tests hardcoded System.Memory 4.5.3 path for #r references.
This version was previously available as a transitive dependency of
OpenTelemetry.Exporter.OpenTelemetryProtocol 1.11.2 but is no longer restored
with version 1.15.3. Update to 4.6.3 which matches SystemMemoryVersion in
eng/Versions.props and is guaranteed to be in the NuGet cache since the
compiler itself depends on it.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Migrate from dn-bot-devdiv-build-rw-code-rw-release-rw PAT to the
dnceng-fsharp-vs-insertion-wif Entra WIF service connection for
authenticating to DevDiv when creating VS insertion PRs.

- Remove DotNet-VSTS-Infra-Access variable group reference
- Add AzureCLI@2 step to acquire bearer token via WIF SC
- Set InsertAccessToken as secret variable from WIF token

Resolves: https://dev.azure.com/dnceng/internal/_workitems/edit/10091

Co-authored-by: Tomas Grosup <Tomas.Grosup@gmail.com>
Co-authored-by: Adam Boniecki <20281641+abonie@users.noreply.github.com>
* Backflow from https://github.com/dotnet/dotnet / 423ddd1 build 312946

Diff: https://github.com/dotnet/dotnet/compare/500589b2e20fb8a427620bb0fe9cedf1c68c5333..423ddd1cabeff54b53750de2d429e6ea121c7fd1

From: dotnet/dotnet@500589b
To: dotnet/dotnet@423ddd1

[[ commit created by automation ]]

* Update dependencies from build 312946
No dependency updates to commit
[[ commit created by automation ]]

* Re-add MSBuild darc NuGet source needed for Microsoft.Build 18.6.4

The codeflow automation incorrectly removed the
darc-pub-DotNet-msbuild-Trusted-13cd968a NuGet source while
Microsoft.Build.Framework 18.6.4 is still referenced in
Version.Details.xml. This package is not available on any standard
feed (nearest stable is 18.4.0 on dotnet-public), causing NU1103
errors across all CI jobs.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Update dependencies from build 313071
No dependency updates to commit
[[ commit created by automation ]]

* Re-add MSBuild darc NuGet source needed for Microsoft.Build 18.6.4

The codeflow automation incorrectly removed the
darc-pub-DotNet-msbuild-Trusted-13cd968a NuGet source while
Microsoft.Build.Framework 18.6.4 is still referenced in
Version.Details.xml. This package is not available on any standard
feed (nearest stable is 18.4.0 on dotnet-public), causing NU1103
errors across all CI jobs.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Retrigger CI after transient agent cancellation

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* add scenario

* remove script extra handling

* include AnonModules

* fix test

* release notes
The expert-reviewer agent had 19 review dimensions and 4 analysis
waves but zero instructions about posting the review to GitHub.
Copilot would analyze thoroughly but never execute gh commands to
create inline comments on the PR.

Add Wave 5: Deliver Review as Inline Comments — mandatory final wave
that instructs the agent to post findings via gh api as a review with
inline comments at the correct file+line from the diff, deduplicate
against existing reviews, and apply the AI-reviewed label.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Reset patterns:
- global.json
- eng/Version.Details.xml
- eng/Version.Details.props
- eng/Versions.props
- eng/common/**
- eng/TargetFrameworks.props
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: New

Development

Successfully merging this pull request may close these issues.

5 participants