[release/11.0-preview4] Revert "Simplify TrimmerSingleWarn intermediate assembly update using MSBuild item Update"#127676
Open
github-actions[bot] wants to merge 1 commit intorelease/11.0-preview4from
Conversation
… MSBuild…" This reverts commit a8f6705.
dotnet-policy-service
Bot
added
the
linkable-framework
github-actions
Bot
added
the
area-Tools-ILLink
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/illink |
This was referenced May 2, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #127656 to release/11.0-preview4
/cc @sbomer
Customer Impact
Hit test failures in dependency flow: ILLink_shows_single_warning_for_packagereferences_only is failing due to an unexpected IL2026 warning for PackageReference.PackageReferenceLib.
The impact is unexpected trim warnings that should be collapsed into a single
IL2104for package references.Regression
Introduced by #125630
Testing
Manual testing of the MSBuild logic confirmed the metadata update is now scoped to the intermediate assembly.
Risk
Low - this is reverting a bad cleanup change. The logic was working before the change.