[DRAFT][PROTO] Push constants right more frequently#127688
Closed
tannergooding wants to merge 1 commit intodotnet:mainfrom
Closed
[DRAFT][PROTO] Push constants right more frequently#127688tannergooding wants to merge 1 commit intodotnet:mainfrom
tannergooding wants to merge 1 commit intodotnet:mainfrom
Conversation
github-actions
Bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
tannergooding
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This draft prototype moves fgPushConstantsRight into gtFoldExpr so constant-right canonicalization happens earlier during JIT folding, rather than only later in morph/optimization. In the CoreCLR JIT, that broadens when compare/commutative trees get rewritten and affects a very hot path.
Changes:
- Adds an early
fgPushConstantsRightcall inCompiler::gtFoldExpr. - Applies the rewrite to commutative ops and compare ops before the existing tier0/minopts bailout.
- Intends to expose more folding opportunities by normalizing operand order sooner.
tannergooding
force-pushed
the
push-cns-right
branch
from
f6b10ab to
f4cb7fe
Compare
tannergooding
force-pushed
the
push-cns-right
branch
from
f4cb7fe to
2fb26fe
Compare
This was referenced May 3, 2026
Open
Member
Author
|
Very minimal diffs, basically just a couple minor optimizations for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a prototype to see what potential optimizations might be missing here...