Refactor example DSL for better consistency and clarity#152
Merged
Conversation
aaronmallen
force-pushed
the
enhance-example-and-banner
branch
from
6596414 to
c146ebf
Compare
Simplified the `example` DSL syntax in commands by replacing array-based declarations with clearer method calls. Updated tests and fixtures to align with the new structure, ensuring improved readability and maintainability.
aaronmallen
force-pushed
the
enhance-example-and-banner
branch
from
c146ebf to
237aee3
Compare
Use this to make the code clearer as we prepare the output and determine indents. Remove all “@SInCE” Yard tags since this is an “@api private” module. Shift some methods further down the module so they’re underneath the other main methods that call them.
Mostly drop “build_” as an unneeded prefix.
timriley
force-pushed
the
enhance-example-and-banner
branch
from
dd53aa5 to
c0922e5
Compare
Simpler and less confusing
This feels more natural
Member
|
@aaronmallen Thanks for doing this! I've poked around at the code and nudged a bunch of things around (and left a trail of commits to show for it). I'm going to come back in a day or so with fresh eyes and probably merge it then. Happy for any feedback you might have in the meanwhile (or even after the fact) :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplified the
exampleDSL syntax in commands by replacing array-based declarations with clearer method calls. Updated tests and fixtures to align with the new structure, ensuring improved readability and maintainability.As discussed here