Pull materialized CDCs through the engine again for arrow conversion with a live connection / transaction#495
Open
evertlammerts wants to merge 3 commits into
Conversation
…with a live connection / transaction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should not have custom paths for duckdb -> arrow conversion for already executed results. Instead, we can feed the materialized column data collection back into duckdb, and let it create either a streaming result, which we can wrap in an arrow stream wrapper, or an arrow collector for eagerly materialized arrow arrays. This way we always have a live client context and transaction around when we create arrow output.
Nice side effect: arrow_c_stream uses 50% less memory with this fix. Performance on other paths is largely the same: