feat: provide asset property for CatalogAsset type#5796
Draft
ndr-brt wants to merge 3 commits into
Draft
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ndr-brt
force-pushed
the
5721-catalog-asset
branch
3 times, most recently
from
0a417bd to
b70b590
Compare
ndr-brt
force-pushed
the
5721-catalog-asset
branch
from
b70b590 to
eea642b
Compare
| } | ||
| return ServiceResult.fromFailure(createResult); | ||
| }); | ||
| logWarningWhenCatalogAssetPropertiesAreNotSet(asset); |
| updatedAsset.onSuccess(a -> observable.invokeForEach(l -> l.updated(a))); | ||
| return ServiceResult.from(updatedAsset); | ||
| }); | ||
| logWarningWhenCatalogAssetPropertiesAreNotSet(asset); |
| Asset %s has no 'endpointURL' property and the DataAddress baseUrl is used instead, please adapt it as the | ||
| DataAddress will be removed from Asset in the forthcoming versions""" | ||
| .formatted(asset.getId())); | ||
| endpointUrl = asset.getDataAddress().getStringProperty(EDC_NAMESPACE + "baseUrl", null); |
| Asset %s has no 'format' property and the DataAddress type is used instead, please adapt it as the | ||
| DataAddress will be removed from Asset in the forthcoming versions""" | ||
| .formatted(asset.getId())); | ||
| format = Optional.ofNullable(asset.getDataAddress()).map(DataAddress::getType).orElse(""); |
ndr-brt
force-pushed
the
5721-catalog-asset
branch
from
32a9d73 to
3c3cae7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Remove binding between
CatalogAssetandDataAddress, as the later will be removed soon from theAssetentity.Added
dcat:endpointURLanddct:formatas mandatory (in V5) properties.In V4 those properties are not mandatory and a warning will be logged if they are not set correctly
Why it does that
remove DataAddress tangles
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Who will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #5721
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.