Set default SVG color to match the SWT.COLOR_WIDGET_FOREGROUND

[DLTKJoelJohansson]

An attempt at fixing #3398.
Let me know what you think.

Thanks!

[DLTKJoelJohansson]

Cant get the build run locally, and jenkins reporting build errors, maybe someone can take a look? Thanks

[merks]

Don't do merge commits; we can't merge this into master in the end because we don't accept merge commits. In fact don't do multiple commits in general. Use rebase. Amend you commit and force push it when you need to make subsequent follow up changes. You'll need to rebase and force push to repair this PR.

[merks]

I'll approve the workflow so you can see any errors in the GitHub actions. Please rebase and force push to get this back on track.

[merks]

See we even fail with a check for merge commits:

[github-actions]

Test Results

  199 files   -  1    199 suites   - 1   31m 57s ⏱️ + 4m 22s
4 683 tests  - 57  4 642 ✅  - 75   20 💤  - 3  6 ❌ +6  15 🔥 +15 
6 817 runs   - 57  6 636 ✅  - 75  160 💤  - 3  6 ❌ +6  15 🔥 +15 

For more details on these failures and errors, see this check.

Results for commit 34c413c. ± Comparison against base commit 5d4df79.

This pull request removes 57 tests.

org.eclipse.swt.graphics.ImageWin32Tests ‑ testDisposeDrawnImageBeforeRequestingTargetForOtherZoom
org.eclipse.swt.graphics.ImageWin32Tests ‑ testDrawImageAtDifferentZooms(boolean)[1] true
org.eclipse.swt.graphics.ImageWin32Tests ‑ testDrawImageAtDifferentZooms(boolean)[2] false
org.eclipse.swt.graphics.ImageWin32Tests ‑ testImageDataForDifferentFractionalZoomsShouldBeDifferent
org.eclipse.swt.graphics.ImageWin32Tests ‑ testImageShouldHaveDimesionAsPerZoomLevel
org.eclipse.swt.graphics.ImageWin32Tests ‑ testRetrieveImageDataAtDifferentZooms(boolean)[1] true
org.eclipse.swt.graphics.ImageWin32Tests ‑ testRetrieveImageDataAtDifferentZooms(boolean)[2] false
org.eclipse.swt.graphics.ImageWin32Tests ‑ test_getImageData_fromCopiedImage
org.eclipse.swt.graphics.ImageWin32Tests ‑ test_getImageData_fromImageForImageDataFromImage
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testByteArrayTransfer
…

♻️ This comment has been updated with latest results.

[merks]

I've approved the workflow again. I'll be out of office for a few hours...

[DLTKJoelJohansson]

Cant seem to figure it out, its failing for Linux builds

[DLTKJoelJohansson]

Okay got it to work now! Moved out the Display.getDefault() call to org.eclipse.swt bundle (In SVGFileFormat, the caller) fixed it.

Thanks @merks for your help. Let me know what you think

[DLTKJoelJohansson]

Maybe not, seems like the Browser tests for Windows are failing. Pretty strange