Update QNX SDP package version#61
Conversation
nradakovic
requested review from
AlexanderLanin,
antonkri and
dcalavrezo-qorix
as code owners
nradakovic
force-pushed
the
nira_qnx_update_804
branch
from
ec4c7f3 to
ed97a91
Compare
| "build_file": "@score_bazel_cpp_toolchains//packages/qnx/aarch64/sdp/8.0.0:sdp.BUILD", | ||
| "sha256": "9039fd6a4a639f06ea977afb93963a6fe8f8c46db727066709370d999c7232e0", | ||
| "aarch64-qnx-sdp_8.0.4": { | ||
| "build_file": "@score_bazel_cpp_toolchains//packages/qnx/x86_64/sdp/8.0.0:sdp.BUILD", |
AlexanderLanin
left a comment
AlexanderLanin
left a comment
There was a problem hiding this comment.
AI-assisted review (Claude):
Critical: 1, Suggestions: 1
This is a small version-bump PR but contains one critical bug in version_matrix.bzl: the aarch64-qnx-sdp_8.0.4 entry points at the x86_64 build file, which will cause the aarch64 QNX toolchain to reference x86_64 binaries (x86_64-pc-nto-qnx8.0.0-ar, x86_64-pc-nto-qnx8.0.0-strip, and x86_64 compiler include paths) instead of the correct aarch64-unknown-nto-qnx8.0.0-* ones. This was already noticed in an existing review comment. The x86_64 entry looks correct.
There's also a minor note on the constraint workaround: the hard-coded 8.0.3 → 8.0.0 mapping has been replaced with 8.0.4 → 8.0.0, so sdp_version = "8.0.3" no longer resolves. Worth noting explicitly if 8.0.3 backwards compat matters.
The lock file and example look correct for x86_64.
| "build_file": "@score_bazel_cpp_toolchains//packages/qnx/aarch64/sdp/8.0.0:sdp.BUILD", | ||
| "sha256": "9039fd6a4a639f06ea977afb93963a6fe8f8c46db727066709370d999c7232e0", | ||
| "aarch64-qnx-sdp_8.0.4": { | ||
| "build_file": "@score_bazel_cpp_toolchains//packages/qnx/x86_64/sdp/8.0.0:sdp.BUILD", |
There was a problem hiding this comment.
AI-assisted review (Claude):
Critical — wrong build file for aarch64.
This entry uses packages/qnx/**x86_64**/sdp/8.0.0:sdp.BUILD but it is keyed as aarch64-qnx-sdp_8.0.4. The previous 8.0.3 entry correctly used packages/qnx/**aarch64**/sdp/8.0.0:sdp.BUILD.
The two build files differ in the binaries they expose:
| file | ar | strip | compiler includes |
|---|---|---|---|
| aarch64/sdp/8.0.0 | aarch64-unknown-nto-qnx8.0.0-ar |
aarch64-unknown-nto-qnx8.0.0-strip |
aarch64-unknown-nto-qnx8.0.0/... |
| x86_64/sdp/8.0.0 | x86_64-pc-nto-qnx8.0.0-ar |
x86_64-pc-nto-qnx8.0.0-strip |
x86_64-pc-nto-qnx8.0.0/... |
Using the x86_64 build file here means any aarch64 QNX build will silently use x86_64 toolchain binaries and include paths, producing broken or incorrect output.
Fix:
| "build_file": "@score_bazel_cpp_toolchains//packages/qnx/x86_64/sdp/8.0.0:sdp.BUILD", | |
| "build_file": "@score_bazel_cpp_toolchains//packages/qnx/aarch64/sdp/8.0.0:sdp.BUILD", |
nradakovic
force-pushed
the
nira_qnx_update_804
branch
from
ed97a91 to
6ab6ba0
Compare
nradakovic
force-pushed
the
nira_qnx_update_804
branch
from
6ab6ba0 to
3c5637b
Compare
3 participants
Rollout of new SDP