Skip to content

Added ROS2-like Rust Examples#104

Merged
JEnoch merged 9 commits intoeclipse-zenoh:examplesfrom
imstevenpmwork:examples
Apr 22, 2024
Merged

Added ROS2-like Rust Examples#104
JEnoch merged 9 commits intoeclipse-zenoh:examplesfrom
imstevenpmwork:examples

Conversation

@imstevenpmwork
Copy link
Copy Markdown

@imstevenpmwork imstevenpmwork commented Apr 3, 2024

This adds ROS2-like examples written in Rust for:

  • Topics listener
  • Topics talker
  • Services client
  • Actions client

Plus slight modifications to the Python ones. Mostly related to directory structure and logs.

Resolves #70
Main PR: #80

@eclipse-zenoh-bot
Copy link
Copy Markdown
Contributor

@imstevenpmwork If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

1 similar comment
@eclipse-zenoh-bot
Copy link
Copy Markdown
Contributor

@imstevenpmwork If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@imstevenpmwork
Copy link
Copy Markdown
Author

@JEnoch I tested these in my vm. Could you review these before I move to the CPP ones 😄 ?

Copy link
Copy Markdown
Member

@JEnoch JEnoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples are working fine 👍

Please address my review comments and complete the README.md similarly to Python's one (adding build instructions)

Question: why did you move the Python scripts into a src subdirectory ?
There is no need for this, and the zenoh-python examples are not in a src subdirectory.

Comment thread examples/rust/Cargo.toml Outdated
Comment thread examples/rust/README.md Outdated
Comment thread examples/rust/src/bin/listener.rs Outdated
Comment thread examples/rust/src/bin/talker.rs Outdated
@imstevenpmwork
Copy link
Copy Markdown
Author

Thanks for the feedback!
Honestly moving the python scripts to the src folder was just preference. I did it to keep it consistent with the rest of the examples which will all have a src directory, also to give more visibility to the readme. But I can roll this back if you think it is not worth it, let me know :)

@imstevenpmwork
Copy link
Copy Markdown
Author

@JEnoch Anything missing in this PR to merge the rust examples into the examples branch?

Comment thread examples/rust/README.md Outdated
@JEnoch JEnoch merged commit 6b68bfb into eclipse-zenoh:examples Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants