fix: Upgrade cyclors 0.2.7 -> 0.3.10 to fix DDS handle refcount overflow#695
Open
cmeng-gao wants to merge 1 commit intoeclipse-zenoh:mainfrom
Open
fix: Upgrade cyclors 0.2.7 -> 0.3.10 to fix DDS handle refcount overflow#695cmeng-gao wants to merge 1 commit intoeclipse-zenoh:mainfrom
cmeng-gao wants to merge 1 commit intoeclipse-zenoh:mainfrom
Conversation
cyclors 0.2.7 embeds CycloneDDS from Aug 2023, which has a 14-bit child refcount limit (max 16,383) in the handle system. When the DDS participant accumulates more children than this limit (e.g. from topic entities created by cdds_create_blob_topic), the refcount overflows into HDL_FLAG_NO_USER_ACCESS (0x04000000), causing all subsequent user-facing DDS API calls to return DDS_RETCODE_BAD_PARAMETER (-3). This manifests as "Error creating DDS Reader/Writer (retcode: -3)" failures after hours of operation in production environments. cyclors 0.3.10 embeds CycloneDDS with the fix from PR eclipse-cyclonedds/cyclonedds#2119 which expands cnt_flags to 64-bit on 64-bit platforms, effectively eliminating the overflow. Additionally: - Remove old iceoryx SHM chunk handling code from dds_types.rs, as cyclors 0.3.x uses PSMX where shared memory is handled transparently by CycloneDDS through ddsi_serdata_to_ser_ref. - Skip dds_shm CI steps on Windows, as cyclors 0.3.10 explicitly rejects iceoryx on Windows (not supported by PSMX plugin). Fixes: eclipse-cyclonedds/cyclonedds#1679 Fixes: eclipse-cyclonedds/cyclonedds#2022 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cyclors 0.2.7 embeds CycloneDDS from Aug 2023, which has a 14-bit child refcount limit (max 16,383) in the handle system. When the DDS participant accumulates more children than this limit (e.g. from topic entities created by cdds_create_blob_topic), the refcount overflows into HDL_FLAG_NO_USER_ACCESS (0x04000000), causing all subsequent user-facing DDS API calls to return DDS_RETCODE_BAD_PARAMETER (-3).
This manifests as "Error creating DDS Reader/Writer (retcode: -3)" failures after hours of operation in production environments.
cyclors 0.3.10 embeds CycloneDDS with the fix from PR eclipse-cyclonedds/cyclonedds#2119 which expands cnt_flags to 64-bit on 64-bit platforms, effectively eliminating the overflow.
Additionally:
Fixes: eclipse-cyclonedds/cyclonedds#1679
Fixes: eclipse-cyclonedds/cyclonedds#2022