feat(player): show original bitrate in quality controls#1534
Open
RyanTheTechMan wants to merge 2 commits into
Open
feat(player): show original bitrate in quality controls#1534RyanTheTechMan wants to merge 2 commits into
RyanTheTechMan wants to merge 2 commits into
Conversation
Display the media's source bitrate beside Original in the quality picker and Playback Settings.
Owner
|
Could you include screenshots? |
When multiple media versions are available, the version label already includes the source bitrate. There is no need to show it twice.
Contributor
Author
Playing media with one version
Playing media with two versions
I also had the idea of adding parentheses around the bitrates like you have for converted versions. rather than: to bring consistency to the UI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes