Skip to content

feat(core): add ManifestStore.fromBundle for bundled artifacts #5876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
killagu merged 2 commits into from
Apr 25, 2026
Merged

feat(core): add ManifestStore.fromBundle for bundled artifacts #5876

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
832ae52
feat(core): add ManifestStore.fromBundle for bundled artifacts
killagu Apr 14, 2026
60804b3
test(core): cover ManifestStore.fromBundle
killagu Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/core/src/loader/manifest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,20 @@ export class ManifestStore {
return new ManifestStore(data, baseDir);
}

/**
* Create a ManifestStore from pre-validated bundled data.
* Skips invalidation checks — the caller (bundler) is responsible for
* guaranteeing the data matches the shipped artifact.
*/
static fromBundle(data: StartupManifest, baseDir: string): ManifestStore {
if (data.version !== MANIFEST_VERSION) {
throw new Error(
`[@eggjs/core] bundled manifest version mismatch: expected ${MANIFEST_VERSION}, got ${data.version}`,
);
}
return new ManifestStore(data, baseDir);
Comment thread
killagu marked this conversation as resolved.
Outdated
}
Comment thread
killagu marked this conversation as resolved.

/**
* Create a collector-only ManifestStore (no cached data).
* Used during normal startup to collect data for future manifest generation.
Expand Down