docs(utils): document bundle module loader#5899
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds README documentation for a new Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying egg with
|
| Latest commit: |
a49016f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1f41d3f0.egg-cci.pages.dev |
| Branch Preview URL: | https://agent-egg-doc-b8a28020.egg-cci.pages.dev |
There was a problem hiding this comment.
Code Review
This pull request adds documentation for the setBundleModuleLoader function in the @eggjs/utils package. The review feedback suggests clarifying that the loader is registered globally via globalThis and refining the terminology used to describe the fallback behavior to standard module resolution.
There was a problem hiding this comment.
Pull request overview
Documents the new bundle module loader hook in @eggjs/utils, clarifying how importModule() can be intercepted for bundled/virtual module resolution.
Changes:
- Add README documentation for
setBundleModuleLoader(loader). - Describe loader fallback behavior (
undefined), default export unwrapping semantics, and how to clear the loader.
Deploying egg-v3 with
|
| Latest commit: |
a49016f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f32d169e.egg-v3.pages.dev |
| Branch Preview URL: | https://agent-egg-doc-b8a28020.egg-v3.pages.dev |
Summary
setBundleModuleLoader(loader)API in@eggjs/utilsVerification
pnpm exec oxfmt --check packages/utils/README.mdNote: the normal pre-commit hook was not used for the final commit because
oxlint --type-aware --fixfails on a Markdown-only staged set withNo files found to lint; the targeted Markdown format check passed.Summary by CodeRabbit