fix(core): skip beforeClose hooks in metadataOnly mode

packages/core/src/lifecycle.ts

@@ -254,14 +254,20 @@ export class Lifecycle extends EventEmitter {
   }
 
   async close(): Promise<void> {
-    // close in reverse order: first created, last closed
-    const closeFns = Array.from(this.#closeFunctionSet);
-    debug('%s start trigger %d beforeClose functions', this.app.type, closeFns.length);
-    for (const fn of closeFns.reverse()) {
-      debug('%s trigger beforeClose at %o', this.app.type, fn.fullPath);
-      await utils.callFn(fn);
-      this.#closeFunctionSet.delete(fn);
+    if (this.#metadataOnly) {
+      debug('%s skip beforeClose functions in metadataOnly mode', this.app.type);
+      this.#closeFunctionSet.clear();
+    } else {
+      // close in reverse order: first created, last closed
+      const closeFns = Array.from(this.#closeFunctionSet);
+      debug('%s start trigger %d beforeClose functions', this.app.type, closeFns.length);
+      for (const fn of closeFns.reverse()) {
+        debug('%s trigger beforeClose at %o', this.app.type, fn.fullPath);
+        await utils.callFn(fn);
+        this.#closeFunctionSet.delete(fn);
+      }
     }
+
     // Be called after other close callbacks
     this.app.emit('close');
     this.removeAllListeners();

packages/egg/test/fixtures/apps/metadata-only-app/app.js

@@ -2,6 +2,9 @@ module.exports = class MetadataOnlyBoot {
   constructor(app) {
     this.app = app;
     app.bootLog = [];
+    app.beforeClose(() => {
+      app.bootLog.push('app.beforeClose');
+    });
   }
 
   configWillLoad() {

packages/egg/test/start.test.ts

@@ -29,6 +29,12 @@ describe('test/start.test.ts', () => {
     });
   });
 
+  it('should skip beforeClose callbacks when closing a metadataOnly app', async () => {
+    const app = await singleProcessApp('apps/metadata-only-app', { metadataOnly: true });
+    await app.close();
+    assert.deepStrictEqual(app.bootLog, ['loadMetadata']);
+  });
+
   describe('normal mode (baseline)', () => {
     let app: SingleModeApplication;
 

tools/egg-bundler/README.md

@@ -23,28 +23,28 @@ path is `<baseDir>/.egg/manifest.json`.
 
 ## Options
 
-| Option | Description |
-| --- | --- |
-| `baseDir` | Application root directory. Required. |
-| `outputDir` | Output directory for the bundled artifact. Required. |
-| `manifestPath` | Path to `manifest.json`. Defaults to `<baseDir>/.egg/manifest.json`. |
-| `framework` | Framework name or absolute path. Defaults to `egg`. |
-| `mode` | Build mode, `production` or `development`. Defaults to `production`. |
-| `tegg` | Accepted by `BundlerConfig`, but not applied by the current implementation yet. |
-| `externals.force` | Package names to always keep external. |
-| `externals.inline` | Package names to force inline even if auto-detected as external. |
-| `pack.buildFunc` | Test hook for replacing the real `@utoo/pack` build entry. |
-| `pack.rootPath` | Override the monorepo workspace root used by `@utoo/pack`. |
+| Option             | Description                                                                     |
+| ------------------ | ------------------------------------------------------------------------------- |
+| `baseDir`          | Application root directory. Required.                                           |
+| `outputDir`        | Output directory for the bundled artifact. Required.                            |
+| `manifestPath`     | Path to `manifest.json`. Defaults to `<baseDir>/.egg/manifest.json`.            |
+| `framework`        | Framework name or absolute path. Defaults to `egg`.                             |
+| `mode`             | Build mode, `production` or `development`. Defaults to `production`.            |
+| `tegg`             | Accepted by `BundlerConfig`, but not applied by the current implementation yet. |
+| `externals.force`  | Package names to always keep external.                                          |
+| `externals.inline` | Package names to force inline even if auto-detected as external.                |
+| `pack.buildFunc`   | Test hook for replacing the real `@utoo/pack` build entry.                      |
+| `pack.rootPath`    | Override the monorepo workspace root used by `@utoo/pack`.                      |
 
 ## Result
 
 `bundle()` resolves with:
 
-| Field | Description |
-| --- | --- |
-| `outputDir` | Absolute output directory. |
-| `files` | Sorted absolute paths for files written into the artifact. |
-| `manifestPath` | Absolute path to `bundle-manifest.json`. |
+| Field          | Description                                                |
+| -------------- | ---------------------------------------------------------- |
+| `outputDir`    | Absolute output directory.                                 |
+| `files`        | Sorted absolute paths for files written into the artifact. |
+| `manifestPath` | Absolute path to `bundle-manifest.json`.                   |
 
 ## Running The Bundle