Conversation
📝 WalkthroughWalkthroughDocumentation updates to egg-bundler wiki pages describing runtime asset copying behavior, tegg module reference path normalization via shared module maps, and bundle module loader preference with dynamic-import fallback. Wiki log entry records the 2026-05-08 documentation changes. ChangesEgg-bundler Runtime and Loader Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying egg with
|
| Latest commit: |
b8a2ce9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a1bcbcb7.egg-cci.pages.dev |
| Branch Preview URL: | https://agent-egg-doc-21d21a67.egg-cci.pages.dev |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for the egg-bundler package to reflect new features including runtime asset copying and tegg manifest path normalization. The changes detail how the bundler handles assets in the app directory and how ManifestLoader ensures consistent module paths. Review feedback identifies an incomplete list of skipped file extensions in the documentation and suggests clarifying the terminology regarding the 'startup manifest' to distinguish it from the generated bundle-manifest.json file.
| baseDir-relative output paths. Source-like files such as `.js`, `.ts`, `.mjs`, | ||
| and `.cjs` are skipped outside force-copy directories, and manifest-known |
There was a problem hiding this comment.
The list of skipped source-like extensions is incomplete. The implementation in Bundler.ts (line 44) defines BUNDLED_SOURCE_EXTENSIONS as including .cts, .jsx, .mts, and .tsx in addition to the ones currently listed. Updating this list will provide more accurate guidance for users.
| baseDir-relative output paths. Source-like files such as `.js`, `.ts`, `.mjs`, | |
| and `.cjs` are skipped outside force-copy directories, and manifest-known | |
| baseDir-relative output paths. Source-like files such as `.js`, `.ts`, `.mjs`, | |
| `.cjs`, `.mts`, `.cts`, `.tsx`, and `.jsx` are skipped outside force-copy directories, and manifest-known |
| absolute paths, and manifest `resolveCache` request aliases. | ||
| - `ManifestLoader` normalizes tegg `moduleReferences` and `moduleDescriptors` | ||
| through the same module map so descriptors and references use matching | ||
| app-relative or package-normalized paths in the bundle manifest. Decorated |
There was a problem hiding this comment.
The term "bundle manifest" is ambiguous here because the bundler now also generates a separate bundle-manifest.json file (as noted in step 6). In this context, it refers to the app startup manifest that is embedded into the worker entry. Using "startup manifest" (consistent with line 31) would be clearer.
| app-relative or package-normalized paths in the bundle manifest. Decorated | |
| app-relative or package-normalized paths in the startup manifest. Decorated |
Deploying egg-v3 with
|
| Latest commit: |
b8a2ce9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0fb9f487.egg-v3.pages.dev |
| Branch Preview URL: | https://agent-egg-doc-21d21a67.egg-v3.pages.dev |
There was a problem hiding this comment.
Pull request overview
Updates the internal wiki documentation for @eggjs/egg-bundler to reflect the current runtime behavior around (a) copying runtime assets into the bundle output and (b) tegg-related manifest path normalization, and records the change in the wiki log.
Changes:
- Document bundler runtime asset copying (
bundle.runtimeAssetsconfig, defaults, and skip rules). - Document tegg manifest
moduleReferences/moduleDescriptorspath normalization and runtime loading behavior. - Add a 2026-05-08 wiki log entry for this documentation sync.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
wiki/packages/egg-bundler.md |
Updates the bundler “Bundle Flow” and “Current Behavior” sections to include runtime asset copying and tegg path normalization details. |
wiki/log.md |
Adds a 2026-05-08 entry recording the doc sync for runtime assets and tegg manifest normalization. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
wiki/packages/egg-bundler.md (1)
37-38: 💤 Low valueConsider explicitly mentioning manifest chunk inclusion for assets.
The wiki log entry (line 9) mentions "bundle manifest chunk inclusion for copied assets," but line 38 only states that the bundler "writes
bundle-manifest.json" without explicitly documenting that the manifest includes information about copied runtime assets. If the manifest includes asset chunks or references, consider adding that detail here for completeness.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@wiki/packages/egg-bundler.md` around lines 37 - 38, The documentation currently says `Bundler` "writes bundle-manifest.json" but doesn't state that the manifest includes chunk entries or references for copied runtime assets; update the description of `Bundler` to explicitly state that `bundle-manifest.json` contains metadata for copied runtime assets (asset chunk entries or references) and that these manifest entries correspond to the absolute output paths returned by `Bundler`, so consumers know the manifest lists the copied asset chunks and their paths.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@wiki/packages/egg-bundler.md`:
- Around line 37-38: The documentation currently says `Bundler` "writes
bundle-manifest.json" but doesn't state that the manifest includes chunk entries
or references for copied runtime assets; update the description of `Bundler` to
explicitly state that `bundle-manifest.json` contains metadata for copied
runtime assets (asset chunk entries or references) and that these manifest
entries correspond to the absolute output paths returned by `Bundler`, so
consumers know the manifest lists the copied asset chunks and their paths.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 7f6eaed1-bec3-46cc-a3ec-eb32805be274
📒 Files selected for processing (2)
wiki/log.mdwiki/packages/egg-bundler.md
Summary
Verification
Summary by CodeRabbit
Release Notes