Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -463,8 +463,8 @@ export class Bundler {
// Since we only output to `.js` now
// Probably remove it in the future
.replace(/\[ext\]/, '.js')
if (rollupFormat === 'esm') {

if (rollupFormat === 'esm') {
fileName = fileName.replace(/\[format\]/, 'esm')
}

Expand Down Expand Up @@ -629,8 +629,9 @@ export class Bundler {
)
const watcher = watch(configs)
watcher.on('event', (e) => {
if (e.code === 'ERROR') {
logger.error(e.error.message)
const code = e.code as string
if (code === 'ERROR' || code === 'FATAL') {
logger.error((e as { error: Error }).error.message)
}
})
} else {
Expand Down
65 changes: 65 additions & 0 deletions test/watch.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
import { Bundler } from '../src'
import logger from '../src/logger'
import { watch } from 'rollup'

jest.mock('rollup', () => ({
rollup: jest.fn(),
watch: jest.fn(),
}))

const mockWatch = watch as jest.Mock

describe('watch mode', () => {
beforeEach(() => {
mockWatch.mockReset()
jest.spyOn(logger, 'error').mockImplementation(() => {})
})

afterEach(() => {
jest.restoreAllMocks()
})

it('logs fatal Rollup watch events', async () => {
const error = new Error('watch failed')

mockWatch.mockReturnValue({
on(event: string, listener: (payload: any) => void) {
expect(event).toBe('event')
listener({ code: 'FATAL', error })
},
})

await new Bundler(
{ input: 'index.js' },
{
configFile: false,
logLevel: 'quiet',
rootDir: __dirname,
}
).run({ watch: true })

expect(logger.error).toHaveBeenCalledWith('watch failed')
})

it('keeps logging normal Rollup watch errors', async () => {
const error = new Error('build failed')

mockWatch.mockReturnValue({
on(event: string, listener: (payload: any) => void) {
expect(event).toBe('event')
listener({ code: 'ERROR', error })
},
})

await new Bundler(
{ input: 'index.js' },
{
configFile: false,
logLevel: 'quiet',
rootDir: __dirname,
}
).run({ watch: true })

expect(logger.error).toHaveBeenCalledWith('build failed')
})
})