Fix - UART listener mode (MIDI Rx) unrecoverable crash after FRAME errors#662
Merged
stephenhensley merged 1 commit intomasterfrom Mar 27, 2025
Merged
Conversation
…ed, and restarted.
Test Results150 tests 150 ✅ 0s ⏱️ Results for commit 00a7616. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a frame, noise, or other error occurred at the peripheral level, it would re-initialize, but not restart reception.
This fix clears the "listener_mode" flag on the peripheral.
When something like MIDI is running, it can perform a, "IsListening" check on the peripheral to check whether or not reception needs to restart.
The check, and recovery were already present in the MIDI transport, but the peripheral never left listener mode after the first call to start receiving.
So this problem should be resolved.
Myself, and a few others, have tested this by directly shorting the Rx line to GND. This was also tested on real-world hardware that could trigger this issue when connectors were being plugged in.
oh.. and there was a fair amount of trailing white space in the file... So that's been stripped out.