Left-shift addresses in Read/WriteDataAtAddress#668
Merged
stephenhensley merged 4 commits intoelectro-smith:masterfrom Jun 16, 2025
Merged
Left-shift addresses in Read/WriteDataAtAddress#668stephenhensley merged 4 commits intoelectro-smith:masterfrom
stephenhensley merged 4 commits intoelectro-smith:masterfrom
Conversation
Contributor
Author
|
Will update existing uses of this library then un-draft |
Contributor
Author
|
Updated all existing uses of affected methods (PCM3060, MCP23x17 drivers) |
Collaborator
|
Confirming that I checked the PCM3060 via the Patch SM Board. |
ndonald2
pushed a commit
to infrasonicaudio/libDaisy
that referenced
this pull request
Feb 5, 2026
* Left-shift addresses in Read/WriteDataAtAddress * Improve comments to specify breaking change * Update i2c addr for PCM3060 driver * Remove i2c addr left shift from MCP23x17 driver --------- Co-authored-by: Coriander Violet Pines <hello@corianderpines.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Left-shift the I2C device addresses passed into Read/WriteDataAtAddress, for consistency with the other I2C functions.
See #622 for details.
Note that this change is not backwards-compatible!