Use a more accessible dropdown#293
Open
jeremypw wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #292
Use a custom factory for Gtk.DropDown that can optionally show mnemonics in the strings and/or a selection marker.
For simplicity only implemented for simple string lists. Therefore the energy usage warning used in the timeout dropdown is not currently styled differently but I do not think the styling added much anyway. A shorter more direct warning is used instead. In principle markup could be used to style part of the string differently but that is left for now.
With keyboard navigation, the grey background for the selected item still does not appear but the marker changes as expected.