fix(subscriptions): prevent newlines in topic and alias textarea inputs#2018
Merged
fix(subscriptions): prevent newlines in topic and alias textarea inputs#2018
Conversation
Prevent Enter key from inserting newlines in subscription topic and alias fields, and strip any existing newline characters when saving.
There was a problem hiding this comment.
Pull request overview
This PR prevents newline characters from being entered or saved in subscription topic and alias fields by adding keyboard event handlers and sanitization logic.
Changes:
- Added event handlers to prevent Enter key from inserting newlines in topic and alias textarea inputs
- Added regex-based sanitization to strip any newline characters before saving subscriptions
- Applied changes consistently to both web and desktop versions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| web/src/components/SubscriptionsList.vue | Added @keydown.enter.native.prevent and @keyup.enter.native.prevent handlers to topic and alias inputs, plus newline stripping in saveSubs() |
| src/components/SubscriptionsList.vue | Added @keydown.enter.native.prevent and @keyup.enter.native.prevent handlers to topic and alias inputs, plus newline stripping in saveSubs() |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e0ce362 to
9c7c1fc
Compare
Red-Asuka
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #2001 and #1874
Test plan