Normalize pip/conda package-name matching to suppress false MarkupSafe WASM errors#216
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix pip solver warning for Markupsafe installation
Normalize pip/conda package-name matching to suppress false MarkupSafe WASM errors
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pip resolution was treating package names as case-sensitive when checking conda-installed packages, so
MarkupSaferequested via pip could be treated as missing even whenmarkupsafewas already present from conda. This produced an incorrect “binary built package not compatible with WASM” warning/error path.Solver behavior: normalize names before conda-installed checks
solverpip.ts(PEP 503-style comparison semantics: case-insensitive,-_.treated equivalently).MarkupSafe,markupsafe, andmarkup_safenow resolve to the same key for conda skip logic.Regression coverage
unittests/tests/pip/test-solver.tsfor:markupsafeMarkupSafe